There is still some cleanup to do for printk, but mainly in the debug code. I noticed the bulk of it is commented out and suspect the rest will follow suit. $ make modules make[1]: Nothing to be done for `all'. CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CC [M] drivers/staging/xgifb/XGI_main_26.o LD [M] drivers/staging/xgifb/xgifb.o Building modules, stage 2. MODPOST 6 modules LD [M] drivers/staging/xgifb/xgifb.ko Sam Hansen (3): xgifb: checkpatch cleanup braces xgifb: checkpatch cleanup __func__ xgifb: checkpatch cleanup printk() -> pr_lvl() drivers/staging/xgifb/XGI_main_26.c | 98 ++++++++++++++++------------------ 1 files changed, 46 insertions(+), 52 deletions(-) -- 1.7.5.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel