Hi,
> Add a space please between KBUILD_MODNAME and the quoted string.
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> Please try not to break format strings into multiple bits.
> It's very error prone and can make it harder to grep.
> It's OK to have the line with the format exceed 80 chars.
>
> pr_err("%s GHID method returned buffer of unexpected length %u\n",
> quickstart->button->name, buffer.length);
Both issues fixed in V3.
Since there were no other comments for V2 patches I'm sending V3 for this
patch only.
--
Szymon K. Janc
szymon@xxxxxxxxxxx
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
