> It doesn't make sense to do this. KERN_ERR puts a "<3>" in front of > the line so we know how important it is, but it's a blank line > because of the "\n" at the start. > > Also the should probably be using pr_err() or dev_err(). > > ... > > These put a "<3>" in the middle of the line which doesn't help > anyone. Rewrite it so it's on one line. Get rid of the OK line. Ah yes. I will fold things up so that printk isn't adding level messages in the middle of the line. In the case where the dmesg line is incrementally being built up, I may patch the generating logic so everything is made from a single call to printk. Thanks for the feedback. I am just picking this up and this is my 2nd patch (set?) ever :) ~s _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
