Re: [patch] Staging: comedi: logical || vs bitwise |

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-01-17 07:31, Dan Carpenter wrote:
These are bitfields and the intend was to OR them together.  A logical
OR here is simply 1.

Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>

You have my ack. I'll just add that since the driver is incomplete, the buggy code is not currently reached. (In fact, as the AI and AO subdevices have neither a range_table nor a range_table_list, the comedi core's COMEDI_INSN/COMEDI_INSNLIST ioctl handlers will return an error for these subdevices before it even calls the driver's insn handlers for these subdevices!)

Acked-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux