On Tue, Jan 10, 2012 at 02:35:52PM +0300, Dan Carpenter wrote:
> On Mon, Dec 26, 2011 at 05:57:35PM +0100, Julian Andres Klode wrote:
> > case NVEC_PS2:
> > - if (msg[2] == 1)
> > + if (msg[2] == 1) {
> > for (i = 0; i < (msg[1] - 2); i++)
> > serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
> > - else if (msg[1] != 2) { /* !ack */
> > - print_hex_dump(KERN_WARNING, "unhandled mouse event: ",
> > - DUMP_PREFIX_NONE, 16, 1,
> > - msg, msg[1] + 2, true);
> > + NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
> > }
> >
> > + else if (msg[1] != 2) /* !ack */
> > + NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);
>
> Kernel style is that the else goes on the same line as the close
> brace and if one side of the if else statement gets braces then they
> both do.
Thanks, seems I overlooked that part of the patch, and checkpatch did
not detect it either (should it?).
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
