On Tue, Jan 3, 2012 at 10:26 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Mon, Jan 02, 2012 at 11:17:18PM -0500, Kevin McKinney wrote: >> This patch removes a typedef definition from CmHost.c >> and places it in the CmHost.h header file where it >> belongs. > > Not really. It's not used outside this file. The warning is > correct, it says that you should just get rid of the typedef and use > enum some_sane_name throughout. > > Typedefs are good for things which can be different type depending > on the config like. For example, "size_t" is a good typedef and it > can be either 32bits or 64bits. > > Sometimes as well you have very complicated types like: > typedef unsigned int __bitwise__ upf_t; > and that's valid. > > But for a normal enum, there is only downside when people hide the > type. > Okay - I will change this to use an enum instead of a typedef. Thanks, Kevin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
