On Fri, 23 Dec 2011, Dan Carpenter wrote:
On Wed, Dec 21, 2011 at 10:12:13AM -0200, Marcos Souza wrote:
/*
static const iw_handler iwctl_handler[] =
{
- (iw_handler) iwctl_commit, // SIOCSIWCOMMIT
(iw_handler) iwctl_giwname, // SIOCGIWNAME
This is the same as before. The other comment was just a style
issue but this change completely breaks everything. :/ You can't
just shift all the array members off by one.
The other removed reference was a commented array. I just removed the
reference to the function and don't removed the entire commented array for
don't mix different issues.
If you saw the source file, you'll see this part of the code that this
array is commented.
Ah. I see.
Changes to commented code can't break things, obviously. I'd
normally prefer it if people didn't introduce breakage into
commented code. This particular breakage especially is subtle and
easily avoidable by just putting a NULL as the first element.
You mentioned that it wasn't appropriate to remove the comment in
this patch. You are planning to remove it soon though, yes?
Of course. I will do this ASAP.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
