On 12/09/2011 03:11 PM, Greg KH wrote: > On Fri, Dec 09, 2011 at 10:49:45AM +0100, Lars-Peter Clausen wrote: >> On 12/08/2011 09:18 PM, Greg KH wrote: >>> On Thu, Dec 08, 2011 at 06:35:53PM +0100, Lars-Peter Clausen wrote: >>>> When updating the scan mask we have to check the actual scan mask for if the >>>> channel is already enabled, not the matching scan mask from the available >>>> scan masks. The bit will already be set there and as a result the actual >>>> scan mask will not get updated and the channel stays disabled. >>>> >>>> Also fix the return value of iio_scan_el_store which would return 1 instead of >>>> the number of bytes written if the channel was already active in the scan mask. >>> >>> You just added a complier warning with this patch: >>> CC [M] drivers/staging/iio/industrialio-buffer.o >>> drivers/staging/iio/industrialio-buffer.c: In function ‘iio_scan_mask_query’: >>> drivers/staging/iio/industrialio-buffer.c:621:8: warning: unused variable ‘mask’ [-Wunused-variable] >>> >>> So I didn't apply it. >> >> Actually you did. At least it is in staging-next. Should I resend a updated >> patch or just a patch removing the now unused mask variable. > > Ugh, you are right, I was messing with my scripts to apply patches at > the time, and forgot to delete this branch. > > So, please send a follow-on patch to fix the warning. > Lars-Peter, have you sent such a patch to Greg? I'm still seeing this warning hence the bump! Just wondering if this got lost in amongst everything else that is going on. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
