On 12/14/2011 03:31 PM, Dan Carpenter wrote: > On Wed, Dec 14, 2011 at 11:15:49AM +0100, Lars-Peter Clausen wrote: >> Marking the function as __must_check doesn't make much sense here. Since it >> will either return an error or the buffer length. So you'll always use the >> returned result one way or the other. > > Isn't that the point of a __must_check? My understanding is that you should use __must_check if it is potentially dangerous to ignore the return value. Which is not the case here, if you don't look at the return value it's kind of pointless to call the function in the first, but it is not dangerous. - Lars _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
