On 12/12/11 16:19, Ravishankar karkala Mallikarjunayya wrote: > This is a patch to the dt3000.c file that fixes up a > printk warning found by the checkpatch.pl tool. > > Converted printks to dev_<levels>. > > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@xxxxxxxxxxxxxxx> There are still numerous issues with these patches, some which have been pointed out to you several times now and still exist: - You are using printk/pr_info, etc where dev_info, etc should be used - You are converting some KERN_CONT to multiline dev_info, and in doing so are now printing useless strings. - Some of the printk's you are 'fixing' should just get removed. Don't blindly replace things, it just creates churn. - You are converting some printks to dev_dbg and leaving dev->minor in the string which is no longer needed. - There are some subtle format changes introduced by the printk changes. Not a big deal, but it should be noted in the changelog. It might affect some userspace tools for the comedi drivers? - You have multiple patches which do the same thing. Why are there two patches for converting printk -> dev_dbg in das1800.c for example? Why not do all of the conversion changes for one file in a single patch? - Some of your patches don't do what they say they do. - You have compile errors still. Some these patches probably are worth applying, but they are just lost in the noise. ~Ryan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
