Re: [PATCH] staging:iio: Setup buffer access functions when allocating the buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 12, 2011 at 11:09:05AM +0100, Lars-Peter Clausen wrote:
> Setup the buffer access functions in the buffer allocate function. There is no
> need to let each driver handle this on its own.

That's nicer.

So, you have different ways to have "buffers" and the driver doesn't
know what type you have, and it's chosen at build time?  Why are you
making the kernel builder make such a decision?  Why not just pick one,
that you know works well, and use it?

You would get rid of a whole level of indirection that I really don't
think you need at all, right?

Make a decision, don't force someone else to make it for you...

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux