On Mon, 2011-11-28 at 12:51 +0100, Valentin Rothberg wrote:
> As noted by the checkpatch script, printk() should include facility level.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@xxxxxxxxxxxxxx>
> ---
> drivers/staging/media/as102/as102_drv.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/as102/as102_drv.h b/drivers/staging/media/as102/as102_drv.h
> index ec63d97..bbe54b4 100644
> --- a/drivers/staging/media/as102/as102_drv.h
> +++ b/drivers/staging/media/as102/as102_drv.h
> @@ -47,8 +47,8 @@ extern int as102_debug;
> } } while (0)
>
> #ifdef TRACE
> -#define ENTER() printk(">> enter %s\n", __func__)
> -#define LEAVE() printk("<< leave %s\n", __func__)
> +#define ENTER() printk(KERN_INFO ">> enter %s\n", __func__)
> +#define LEAVE() printk(KERN_INFO "<< leave %s\n", __func__)
> #else
> #define ENTER()
> #define LEAVE()
KERN_DEBUG is probably better and it's also
probably better to use the function tracer and
just remove these ENTER/LEAVE defines and uses.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
