Can you change the Subject to include the word "Staging" so that we
know which subsystem this affects? Something like this:
[PATCH] Staging: 68360serial.c: formatted into linux coding style
(Obviously we know because we're on the Staging mailing list, but
when all the patches get merged together in Linus's kernel they have
to have the subsystem marked).
On Sat, Nov 26, 2011 at 10:55:29AM +0100, Valentin Rothberg wrote:
> I ran over the entire code and fixed coding style warnings and errors
> according to the /scripts/checkpatch.pl script. These changes include
> fixing whitespaces, improving the readability of the code as well as
> fixing evil typedefs.
Could you break that up into three separate patches:
1) fixing whitespaces
2) improving the readability
3) evil typedefs
> The code is still very bad, but now hopefully
> easier to read.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@xxxxxxxxxxxxxx>
>
> --- a/staging/drivers/staging/serial/68360serial.c 2011-11-25
> 16:28:50.000000000 +0100
> +++ b/staging/drivers/staging/serial/68360serial.c 2011-11-26
^^^^^^^
This doesn't apply with patch -p1.
You should be able to apply the patch with:
cd path/to/src
cat raw_email.txt | git am
I couldn't get this to apply anyway. Did you write it against
linux-next? Your email client is line wrapping the text as well so
that's part of the problem. Read Documentation/email-clients.txt.
Send the email to yourself first and verify that it applies with
git am and then resend.
> @@ -229,14 +229,14 @@ char *console_fifos[CONSOLE_NUM_FIFO * C
> /* The async_struct in serial.h does not really give us what we
> * need, so define our own here.
> */
> -typedef struct serial_info {
> +struct serial_info {
This change here changes the typedef into a declaration (you didn't
remove the ser_info_t). This typedef is needed to make the compile
work. The compile doesn't work as it is, but there is no need to
break it more...
> int magic;
> int flags;
>
regards,
dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
