On Sat, Nov 26, 2011 at 10:55:29AM +0100, Valentin Rothberg wrote: > I ran over the entire code and fixed coding style warnings and errors > according to the /scripts/checkpatch.pl script. These changes include > fixing whitespaces, improving the readability of the code as well as > fixing evil typedefs. The code is still very bad, but now hopefully > easier to read. > > Signed-off-by: Valentin Rothberg <valentinrothberg@xxxxxxxxxxxxxx> > > --- a/staging/drivers/staging/serial/68360serial.c 2011-11-25 > 16:28:50.000000000 +0100 It's better, yes, but the patch is linewrapped. Also, please only do one thing per patch, and fix one coding style thing at time, making it able to be reviewed properly. But finally, this patch is about to be deleted from the tree in another few kernel versions. Do you really have the hardware for this driver and does it work for you? It was moved into the staging directory because it was very broken. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
