On Thu, Nov 24, 2011 at 09:11:14PM +0100, Andreas Ruprecht wrote: > The checkpatch.pl script marks the function "strict_strtol" > as obsolete and suggests replacing it with "kstrtol". > Some of these change the behavior, so those should be broken out and justified more clearly. Every behavior change you need to say what changed, and why. I can't describe how annoyed I get when I'm going through old patches and I see something like bc9025bdc "blah blah blah cleanups simplifications. ps I also fixed a locking bug." The bug fix is the important bit, and the cleanups can be mentioned in the ps. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
