Re: [PATCH 1/4] staging: line6: add Pod HD300 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 23, 2011 at 08:20:42AM +0000, Stefan Hajnoczi wrote:
> +	line6 = &podhd->line6;
> +	if (line6 == NULL)
> +		return;

The address of a pointer is rarely NULL.  In this case, although 
->line6 is the first member of the struct, we've already verified
that podhd is not NULL so line6 can't be NULL.  (Obviously don't
resend, I'm just pointing it out.  Plus it's always nice to know that
people are reading your patches.).

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux