Re: [PATCH] Staging: iio/adc: small data type glitch for kstrtoul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 23, 2011 at 09:11:23PM +0100, Andreas Ruprecht wrote:
> When doing changes from strict_strtoul to kstrtoul I didn't check if the target variable was of the right data type, and missed a long used as the parameter for kstrtoul.
> Thanks to Dan for pointing this out.
> 

Hang on.  You have to do a proper v2 patch unless this has been
merged into the staging tree already.

1) Redo the original patch.
2) Change the subject to [PATCH v2] blah blah blah.
3) Under the "---" line describe what changed since version 1.

There is no hurry to send a fixed patch.  Take your time and do it
carefully.

Also could you line wrap the patch description?  I'm not sure there
is a firm standard for this but probably 72 characters per line is
standard on a lot of email lists.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux