On Tue, Nov 15, 2011 at 10:41:44AM -0500, Sean MacLennan wrote: > On Tue, 15 Nov 2011 09:20:59 +0300 > Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > Doesn't this driver still need some work? > > I have been using the driver on my laptop since sometime last year. So > it is functional. Or did you mean needs work to make it look clean? > > > Why does the Makefile hardcode that CONFIG_PM is enabled? > > I only looked at rtl8192e/rtllib.h, but that seems like someone > > could go through there and tidy things up and delete the unused bits. > > Yes. I didn't want to spend a lot of time cleaning it up until it was > decided that this was the way to go. i.e. Two directories and multiple > drivers as opposed to the original one directory, one driver. That's fine, but for now, please keep them in the drivers/staging/ directory, as the code itself is not ready to be merged to the "real" portion of the kernel without a lot of work. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
