> -----Original Message----- > From: Jiri Kosina [mailto:jkosina@xxxxxxx] > Sent: Sunday, November 13, 2011 3:01 PM > To: Dmitry Torokhov > Cc: KY Srinivasan; gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; ohering@xxxxxxxx; > joe@xxxxxxxxxxx > Subject: Re: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging > > On Sun, 6 Nov 2011, Dmitry Torokhov wrote: > > > > I am not a hid expert; but all hid low level drivers appear to do this. > > > Initially, I was directly invoking hid_connect() directly and based on your > > > Input, I chose to use hid_hw_start() which all other drivers are using. > > > > Note that the users of hid_hw_start() actually are not low level > > drivers, such as usbhid or bluetooth hidp, but higher-level drivers, > > such as hid-wacom, hid-a4tech, etc. Since your driver is a low-level > > driver (a provider so to speak) it should not call hid_hw_start() on its > > own but rather wait for the hid code to do it. > > > > Still, I am not a HID expert either so I'll defer to Jiri here. > > Hi, > > my understanding is that hv driver is actually a bit special in this > respect -- it's actually all-in-one both low-level and high-level driver. > I take it that there is not ever going to be a different high-level driver > using low-level hv transport (is that correct, KY?), so this might indeed > be an acceptable layout of the driver. You are right Jiri. While this is a low level transport driver, there will never be a another higher level driver using this transport. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
