Re: [PATCH] drivers/staging/vt6656/iwctl.c: Remove PRINT_K macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 07, 2011 at 07:27:52AM -0300, Marcos Souza wrote:
> 2011/11/7, Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> > Hi Marcos,
> >
> > This should be sent to devel@xxxxxxxxxxxxxxxxxxxx as well.
> On copy this time
> > DBG_PRT() is just as bad as PRINT_K().  The first example in
> > iwctl_siwscan() should be either pr_debug() or dev_dbg().  Also the
> > message itself is wrong.
> So, I'll send patches to change all these print_k and dbg_prt to dev_dbg

It's not as simple as doing a sed over the driver.  You have to look
at each one and decide what it should be.  I only looked at the first
PRINT_K() and said specific one should be a pr_debug() not that all
of them should.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux