On 11/06/2011 10:49 PM, Jonathan Cameron wrote: > On 11/06/2011 09:49 PM, Jesper Juhl wrote: >> If ad7280_read_all_channels() returns <0 then we'll leak the memory >> allocated to 'channels' when we return and that variable goes out of >> scope. >> This patch fixes the leak. >> > Looks right to me - good spot. Only choice is whether a single exit > point makes sense rather than undwinding it here? Michael? > I'm happy with either solution, hence the ack. A similar patch has already been sent last week and should be in Gregs queue. See: http://comments.gmane.org/gmane.linux.kernel.iio/2433 - Lars _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
