Re: [PATCH] Staging: bcm: Fix information leak in ioctl, IOCTL_BCM_REGISTER_READ_PRIVATE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,
On Sat, Nov 5, 2011 at 2:44 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> This looks like another info leak the same as the one in
> IOCTL_BCM_REGISTER_READ_PRIVATE.  Could you change
> "IoBuffer.OutputLength" to "bytes" here?
>
>>                               Status = -EFAULT;
>> +             } else {
>> +                     Status = bytes;
>> +             }

Sure, I noticed this also, but thought we would fix in another patch.

> When you've made that change can you resend with a:
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Will do.

Thanks,
Kevin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux