On 04/11/11 10:12, Manohar Vanga wrote:
> The functions vme_add_bus() and vme_remove_bus() were only being used
> in the vme_register_bridge() and vme_unregister_bridge() functions
> respectively. This patch gets rid of them and moves their code to
> vme_register_bridge() and vme_unregister_bridge().
>
> Signed-off-by: Manohar Vanga <manohar.vanga@xxxxxxx>
Acked-by: Martyn Welch <martyn.welch@xxxxxx>
> ---
> drivers/staging/vme/vme.c | 26 ++++++++------------------
> 1 files changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 3cbc69c..4c6dc69 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1307,7 +1307,12 @@ EXPORT_SYMBOL(vme_slot_get);
>
> /* - Bridge Registration --------------------------------------------------- */
>
> -static int vme_add_bus(struct vme_bridge *bridge)
> +static void vme_dev_release(struct device *dev)
> +{
> + kfree(dev_to_vme_dev(dev));
> +}
> +
> +int vme_register_bridge(struct vme_bridge *bridge)
> {
> int i;
> int ret = -1;
> @@ -1327,8 +1332,9 @@ static int vme_add_bus(struct vme_bridge *bridge)
>
> return ret;
> }
> +EXPORT_SYMBOL(vme_register_bridge);
>
> -static void vme_remove_bus(struct vme_bridge *bridge)
> +void vme_unregister_bridge(struct vme_bridge *bridge)
> {
> struct vme_dev *vdev;
> struct vme_dev *tmp;
> @@ -1343,22 +1349,6 @@ static void vme_remove_bus(struct vme_bridge *bridge)
> list_del(&bridge->bus_list);
> mutex_unlock(&vme_buses_lock);
> }
> -
> -static void vme_dev_release(struct device *dev)
> -{
> - kfree(dev_to_vme_dev(dev));
> -}
> -
> -int vme_register_bridge(struct vme_bridge *bridge)
> -{
> - return vme_add_bus(bridge);
> -}
> -EXPORT_SYMBOL(vme_register_bridge);
> -
> -void vme_unregister_bridge(struct vme_bridge *bridge)
> -{
> - vme_remove_bus(bridge);
> -}
> EXPORT_SYMBOL(vme_unregister_bridge);
>
> /* - Driver Registration --------------------------------------------------- */
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)1327322748 | Barbirolli Square, Manchester,
E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
