Re: [PATCH v2 2/3] Staging: bcm: hostmibs: White spaces and indentation fixes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 02, 2011 at 09:45:26PM -0300, Diego F. Marfil wrote:
> +	for (nClassifierIndex = 0; nClassifierIndex < MAX_CLASSIFIERS; nClassifierIndex++)
> +		if (Adapter->astClassifierTable[nClassifierIndex].bUsed == TRUE)
> +			memcpy((PVOID) & pstHostMibs->
> +			       astClassifierTable[nClassifierIndex],
> +			       (PVOID) & Adapter->
> +			       astClassifierTable[nClassifierIndex],
> +			       sizeof(S_MIBS_CLASSIFIER_RULE));
> +

Please leave the curly braces here.  Multiple lines of code get keep
the curly braces even when they aren't needed for semantic reasons.
Especially in this case, it's really hard to read without the braces.

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux