Re: [PATCH] Staging: bcm: Fix information leak in ioctl, IOCTL_BCM_REGISTER_READ_PRIVATE

[Kevin McKinney <klmckinney1@xxxxxxxxx>]

On Tue, Nov 1, 2011 at 2:18 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Oct 31, 2011 at 09:18:16PM -0400, Kevin McKinney wrote:
>> diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
>> index 61f878b..f10ecd8 100644
>> --- a/drivers/staging/bcm/InterfaceMisc.c
>> +++ b/drivers/staging/bcm/InterfaceMisc.c
>> @@ -48,15 +48,15 @@ INT InterfaceRDM(PS_INTERFACE_ADAPTER psIntfAdapter,
>>
>>       } while ((retval < 0) && (usRetries < MAX_RDM_WRM_RETIRES));
>>
>> -     if (retval < 0) {
>> +     if (retval < 0) {
>>               BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, RDM, DBG_LVL_ALL, "RDM failed status :%d, retires :%d", retval, usRetries);
>>               psIntfAdapter->psAdapter->DeviceAccess = FALSE;
>>               return retval;
>> -     } else {
>> -             BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, RDM, DBG_LVL_ALL, "RDM sent %d", retval);
>> -             psIntfAdapter->psAdapter->DeviceAccess = FALSE;
>> -             return STATUS_SUCCESS;
>>       }
>> +
>> +     BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, RDM, DBG_LVL_ALL, "RDM sent %d", retval);
>> +     psIntfAdapter->psAdapter->DeviceAccess = FALSE;
>> +     return retval;
>
> This should be:
>
> return STATUS_SUCCESS;
Shoot!!! I thought I got them all. Okay, I will fix.

Thanks,
Kevin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel