On Tue, 2011-10-25 at 17:19 -0700, K. Y. Srinivasan wrote: > Make some state that is boolean in nature, a boolean variable. [] > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c [] @@ -148,7 +148,7 @@ struct mousevsc_prt_msg { > */ > struct mousevsc_dev { > struct hv_device *device; > - unsigned char init_complete; > + bool init_complete; > struct mousevsc_prt_msg protocol_req; > struct mousevsc_prt_msg protocol_resp; > /* Synchronize the request/response if needed */ > @@ -159,7 +159,7 @@ struct mousevsc_dev { > unsigned char *report_desc; > u32 report_desc_size; > struct hv_input_dev_info hid_dev_info; > - int connected; > + bool connected; > struct hid_device *hid_device; > }; One of the bools should be moved to be adjacent to the other. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel