On 10/24/11 10:03, Maxin B John wrote: > Hi, > > On Mon, Oct 24, 2011 at 11:51 AM, Jonathan Cameron <jic23@xxxxxxxxx> wrote: >> >> >> On 10/22/11 06:15, Maxin B John wrote: >>> Hi, >>> >>> On Fri, Sep 2, 2011 at 1:55 PM, Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@xxxxxxxxxxxxxxxx> wrote: >>>> On 09/02/11 10:41, Maxin B. John wrote: >>>>>> Don't overwrite the error code. For example, the lower layers can >>>>>> return -EAGAIN and that's more useful than just returning -EIO every >>>>>> time. >>>>> Ahh.. Thanks a lot for explaining this. >>>>> >>>>>> Your fix works, but it's not very clean. Just add a "*id = ret;" >>>>>> line before the "return 0;" and that's it. (It doesn't make sense >>>>>> to pass a pointer to "id" and not use it). >>>>> Dan, yes, I agree with you. This fix is much much better than what I >>>>> had in my mind. >>>>> >>>>>> Yikes - I wonder why my various compilers don't throw that up. >>>>> I guess, in "iio-blue.git" tree, the 'id = 0' suppresses this warning. >>>> That'd do it. oops. >>>> >>>> Ideally keep the white space but doesn't really matter. Either send on >>>> to Greg directly or I'll add it to iio-blue and send on with the next fixes >>>> series - probably this afternoon. >>>>> >>>>> Signed-off-by: Maxin B. John <maxin.john-Re5JQEeQqe8AvxtiuMwx3w@xxxxxxxxxxxxxxxx> >>>> Acked-by: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@xxxxxxxxxxxxxxxx> >>>> >>> >>> Sorry for the delay in replying to this mail. I am curious about the >>> status of this patch. I couldn't locate this patch at iio-blue.git as >>> it is not present in kernel.org now >>> (http://git.kernel.org/?p=linux/kernel/git/jic23/iio-blue.git;a=summary) >>> Please ignore this mail if you have already added this patch to your tree. >> Ah, sorry I slipped up here and should have noticed it didn't go directly to >> Greg. Just to check, with everyone I have author as Dan, reporter as Maxin >> and have signed off myself (it's going through my tree anyway now). >> >> I think from looking back it was Dan's suggestion in response to Maxin's >> patch. Hence convention would be a sign off from Dan and perhaps an >> Ack from Maxin? > > Sounds good to me. > > Acked-by: Maxin B. John <maxin.john@xxxxxxxxx> > As Dan reckon's you are the author I'll switch that to a signed-off by. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
