On Thu, Oct 20, 2011 at 11:48:49AM +0530, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the pcl818.c file that fixes up a warning > found by the checkpatch.pl tool. > Fix brace coding style and NULL initilization issue. > Converted printks to dev_printk. > Removed unnecessary printk statements. That's a lot of different things all at once here. Please only do one "change" per patch. So this should be split up into multiple patches. Same goes for your other 24 patches, care to break them up as well, as it's easier to review and verify that you got it correct. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
