On Tue, Oct 18, 2011 at 09:56:34PM +0200, Tomas Winkler wrote:
> wd_ops and wd_info structures are local to wd.c so mark them static
>
> Cc: Oren Weil <oren.jer.weil@xxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
> drivers/staging/mei/wd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mei/wd.c b/drivers/staging/mei/wd.c
> index ffca7ca..cb3f92d 100644
> --- a/drivers/staging/mei/wd.c
> +++ b/drivers/staging/mei/wd.c
> @@ -331,14 +331,14 @@ static int mei_wd_ops_set_timeout(struct watchdog_device *wd_dev, unsigned int t
> /*
> * Watchdog Device structs
> */
> -const struct watchdog_ops wd_ops = {
> +static const struct watchdog_ops wd_ops = {
> .owner = THIS_MODULE,
> .start = mei_wd_ops_start,
> .stop = mei_wd_ops_stop,
> .ping = mei_wd_ops_ping,
> .set_timeout = mei_wd_ops_set_timeout,
> };
> -const struct watchdog_info wd_info = {
> +static const struct watchdog_info wd_info = {
> .identity = INTEL_AMT_WATCHDOG_ID,
> .options = WDIOF_KEEPALIVEPING,
> };
> --
> 1.7.4.4
>
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
As others have pointed out, I have to reject any patch you send me with
such a footer.
Please work with your corporate lawyers to remove it, as it is in direct
contridiction with your "Signed-off-by:" line above, so what should I
believe?
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
