On Sun, Oct 16, 2011 at 8:23 AM, Julian Andres Klode <jak@xxxxxxxxxxxxx> wrote: > On Sat, Oct 15, 2011 at 10:54:43PM +0200, Piotr Chmura wrote: >> staging as102: cleanup - formatting code >> >> Cleanup code: change double spaces into single, put tabs instead of spaces where they should be. >> >> Signed-off-by: Piotr Chmura<chmooreck@xxxxxxxxxxxxxx> >> Cc: Devin Heitmueller<dheitmueller@xxxxxxxxxxxxxx> >> Cc: Greg HK<gregkh@xxxxxxx> > > Just a few hints from my side. Most of my comments apply to multiple other parts > of the code, but I did not want to quote everything and you should be able to > find the other parts I did not mention explicitely as well. > > I don't have much knowledge of kernel code style, but wanted to point out a few > things that seem to be obviously wrong or uncommon, and stuff I wouldn't do. There > may be a few false positives and some things missing. > > [And yes, I actually only wanted to comment on the two-space thing, but I somehow > ended up reading the complete patch or the first half of it]. I think that rather than having Piotr rework the whitespace fifty times until everybody is satisfied, let's get a functional patch series into the staging tree and then people can submit whitespace cleanup patches to their hearts content. That said, Piotr, I would not spend effort reworking the existing patch per Julian's request. Fix the issues related to the history that I mentioned in my previous email (which would be required to get it into staging), and then the people who have nothing better to do than obsess about whitespace can submit incremental patches on top of yours which address their concerns. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
