Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 11, 2011 at 12:11:31PM +0200, Pelle Windestam wrote:
> On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@xxxxxxxxx> wrote:
> > Fixed the checkpatch warning about sing simple_strtoul instead of
> > kstrtoul() in panel.c.
> >
> > Signed-off-by: Pelle Windestam <iceaway@xxxxxxxxx>
> > ---
> >  drivers/staging/panel/panel.c |   10 ++++------
> >  1 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index b303b7e..4683d5f 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
> >                        break;
> >
> >                while (*esc) {
> > -                       char *endp;
> > -
> >                        if (*esc == 'x') {
> >                                esc++;
> > -                               lcd_addr_x = simple_strtoul(esc, &endp, 10);
> > -                               esc = endp;
> > +                               if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> > +                                       break;
> >                        } else if (*esc == 'y') {
> >                                esc++;
> > -                               lcd_addr_y = simple_strtoul(esc, &endp, 10);
> > -                               esc = endp;
> > +                               if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> > +                                       break;
> >                        } else
> >                                break;
> >                }
> > --
> > 1.7.3.4
> >
> >
> 
> Was there any reason for not accepting this patch?

I don't recall ever seeing it before, care to resend it against the
latest linux-next tree so I can apply it?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux