On Mon, Oct 10, 2011 at 06:01:48PM -0700, Joe Perches wrote: > On Mon, 2011-10-10 at 17:03 -0700, Greg KH wrote: > > On Tue, Oct 04, 2011 at 01:35:00PM -0700, Joe Perches wrote: > > > Corrections to format strings and logging code alignment. > > > DPRINT_<LEVEL> formats do not use newline terminations. > > > dev_<level> formats use newline terminations. > > > Coalesce format strings. > > > Align arguments as appropriate. > > > Miscellaneous trailing period deletions for consistency. > > > Miscellaneous typo "satisy" to "satisfy" correction. > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > > Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > > --- > > > I believe this should still apply after moving some files > > > out of staging. > > Really? This doesn't apply at all to my tree, what did you make it > > against? > > No offense Greg, you volunteered for a tough job but > this is one of the reasons why I try not to do much > with staging. Sychronization is burdensome. If you sent this against the linux-next tree, it would have applied fine. Don't blame me for you not doing the correct thing here. > It eventually gets resolved, but it's tedious. > > I did this patch against your staging tree > url = git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > Last commit: 9b13776977d45505469edc6decc93e9e3799afe2 That's the master branch, and corrisponds with Linus's tree, why would you make it against that? A simple look at it would have shown you that this was not correct. > You, unlike (almost?) every other maintainer don't > keep your development branch in a separate git tree > in branch master, you have a staging-next branch > in the staging-next tree. Most maintainers put their -next stuff in a next branch, as it's simpler that way. If you would like your patch accepted, you need to make it against the correct tree, it's that simple, and nothing new, it's been this way for years. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
