Re: [PATCH v3 21/25] staging: brcm80211: use endian annotated structures in brcmsmac

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/9/30 Franky Lin <frankyl@xxxxxxxxxxxx>:
> From: Arend van Spriel <arend@xxxxxxxxxxxx>


> +struct d11rxhdr_le {
> +       __le16 RxFrameSize;
> +       u16 PAD;
> +       __le16 PhyRxStatus_0;
> +       __le16 PhyRxStatus_1;
> +       __le16 PhyRxStatus_2;
> +       __le16 PhyRxStatus_3;
> +       __le16 PhyRxStatus_4;
> +       __le16 PhyRxStatus_5;
> +       __le16 RxStatus1;
> +       __le16 RxStatus2;
> +       __le16 RxTSFTime;
> +       __le16 RxChan;
> +} __packed;

So you decided to use __packed here anyway for some reason? ;)


>  struct d11rxhdr {
>        u16 RxFrameSize;
>        u16 PAD;
> @@ -1392,20 +1407,18 @@ struct d11rxhdr {
>        u16 RxStatus2;
>        u16 RxTSFTime;
>        u16 RxChan;
> -} __packed;
> +};

You should be right, none compiler should break that alignment...
still no idea why usage of __packed hurt anyone, made code clear
according to me.

-- 
Rafał
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux