Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 10, 2011 at 07:42:17AM +0200, Pelle Windestam wrote:
> -static struct pci_device_id rtsx_ids[] = {
> -	{ 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> -	{ 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> -	{ 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = {
> +	{ 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID,
> +	  PCI_CLASS_OTHERS << 16, 0xFF0000 },
> +	{ 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID,
> +	  PCI_CLASS_OTHERS << 16, 0xFF0000 },
> +	{ 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID,
> +	  PCI_CLASS_OTHERS << 16, 0xFF0000 },
>  	{ 0, },
>  };

This looked nicer in the original version.  I know that checkpatch
complains but in the end, checkpatch is just a perl script.  It's
less sentient than a squirrel.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux