Re: [PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni_atmio.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nah.  For this kind of thing you need to redo the first one, not
just write another patch on top of it.  The v2 patch should have a
subject with [patch v2] blah blah blah.  After the Signed-off-by line
put three dashes "---" and then the changes between v1 and v2.

Signed-off-by:  you
---
v2:  whitespace changes for Joe Perches.

Joe should be added to the CC list.  Hopefully it should be sent in
the same thread as a response to Joe's email.  Use the In-Reply-To
header.

Also the "};" on the first hunk should be moved down a line as well.

And the subject and the commit message on the first patch were
mangled.  There wasn't a blank line after the Subject and before the
changelog.  It need another blank line in front of the Signed-off-by
line and this patch doesn't have a Signed-off-by line.  (These things
matter because the process is scripted).

If you want you can leave linux-kernel off the CC list.  They don't
care about whitespace patches to staging.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux