There are some trivial static checker things that could be cleaned up. drivers/staging/et131x/et131x_initpci.c +489 et131x_adjust_link(45) error: we previously assumed 'phydev' could be null (see line 475) drivers/staging/et131x/et131x_initpci.c +505 et131x_adjust_link(61) warn: variable dereferenced before check 'phydev' (see line 498) (probably the null check should be removed?) drivers/staging/et131x/et1310_mac.c:376:44: warning: incorrect type in initializer (different address spaces) drivers/staging/et131x/et1310_mac.c:376:44: expected struct txmac_regs *txmac drivers/staging/et131x/et1310_mac.c:376:44: got struct txmac_regs [noderef] <asn:2>*<noident> drivers/staging/et131x/et1310_mac.c:383:28: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et1310_mac.c:383:28: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et1310_mac.c:383:28: got unsigned int *<noident> drivers/staging/et131x/et1310_mac.c:385:31: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et1310_mac.c:385:31: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et1310_mac.c:385:31: got unsigned int *<noident> (it just needs an __iomem anotation). drivers/staging/et131x/et131x_initpci.c:556:5: warning: symbol 'et131x_mii_probe' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:246:5: warning: symbol 'et131x_ioctl' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:264:5: warning: symbol 'et131x_set_packet_filter' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:326:6: warning: symbol 'et131x_multicast' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:399:5: warning: symbol 'et131x_tx' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:432:6: warning: symbol 'et131x_tx_timeout' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:490:5: warning: symbol 'et131x_change_mtu' was not declared. Should it be static? drivers/staging/et131x/et131x_netdev.c:543:5: warning: symbol 'et131x_set_mac_addr' was not declared. Should it be static? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
