On 30/09/11 23:18, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the cb_pcidio.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/cb_pcidio.c | 27 +++++++++++++++------------
> 1 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidio.c b/drivers/staging/comedi/drivers/cb_pcidio.c
> index 79477a5..85cc78d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidio.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidio.c
> @@ -184,7 +184,8 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> int index;
> int i;
>
> - printk("comedi%d: cb_pcidio: \n", dev->minor);
> + dev_info(&pcidev->dev, "comedi%d: cb_pcidio:\n",
> + dev->minor);
>
> /*
> * Allocate the private structure area. alloc_private() is a
> @@ -223,8 +224,9 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> }
> }
>
> - printk("No supported ComputerBoards/MeasurementComputing card found on "
> - "requested position\n");
> + dev_err(&pcidev->dev, "No supported"
> + " ComputerBoards/MeasurementComputing"
> + " card found on requested position\n");
printk strings should be on a single line (80 column rule doesn't apply)
so that they can be easily grepped for. There are many instances which
need to be fixed in this series.
~Ryan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
