Re: [PATCH] staging: comedi: Added log subjects to printk()s in pcmmio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The KERN_ERR stuff is only supposed to be used at the start of the
> line of output.  (The previous KERN_INFO printk didn't have a new
> line at the end).
>
> All this code needs to be rewritten so each printk() only prints
> one line.  Otherwise you could get messages printed out in the
> middle of other messages and it looks like crap.
>

*args*, sorry for messing it up, I will take care of it.

> This code is trickier than it looks.  Quite a few newbies have run
> into trouble here.  My advice is to start with something that looks
> tricky so at least if you mess up, you were doing something awesome.
> :)
>
> regards,
> dan carpenter
>
>

Thanks for the advice :D

regards,
Johannes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux