Re: [PATCH 3/3] Staging: bcm: Add min/max restrictions for IOCTL_BCM_REGISTER_READ_PRIVATE.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-09-26 at 21:52 -0400, Kevin McKinney wrote:
> On Mon, Sep 26, 2011 at 4:45 PM, Kevin McKinney <klmckinney1@xxxxxxxxx> wrote:
> > On Mon, Sep 26, 2011 at 12:00 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> >> On Sun, 2011-09-25 at 21:15 -0400, Kevin McKinney wrote:
> >>> This patch fixes two issues within bcm/Bcmchar.c.
[]
> >>               Bufflen = IoBuffer.OutputLength + (4 - IoBuffer.OutputLength%4)%4;
> >> Not your issue, but because it's near the patched bits:
> >> Because of the two modulos, this is not straightforward.
> >> Perhaps a temporary helps.
> >>                Bufflen = IoBuffer.OutputLength;
> >>                u16 extra = Bufflen % 4;
> >>                if (extra)
> >>                        Bufflen += 4 - extra;
> On second thought; if it is okay, I will submit another patch to fix
> this issue.

Of course it's OK Kevin.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux