Am Freitag 23 September 2011, 21:18:19 schrieb Dan Carpenter: > On Fri, Sep 23, 2011 at 06:37:56PM +0200, Julian Andres Klode wrote: > > From: Marc Dietrich <marvin24@xxxxxx> > > > > Rework the tegra slave controller init to look more like in > > tegra-i2c.c. This makes the nvec init reliable. > > That's wonderfully vague... As Julian said, we don't have the chip docu. We had some problems that the slave controller sometimes didn't initialized with the old code (based on the 2.6.32 driver from NVIDIA). Doing it similar to i2c-tegra fixed most (or all) of the problems. Another reason is that it makes it easier to move the hardware init to i2c- tegra in a later patch series. I agree that the commit message should be a bit more detailed, e.g. "Rework the tegra slave controller init. Do it similar as for the master controller in drivers/i2c/busses/i2c-tegra.c This fixes a problem with the slave controller which somethimes failed to initialize. It also makes it easier to move the initialization to the i2c-tegra driver in the future." Ok? Marc _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
