On Sat, Sep 24, 2011 at 01:49:55PM +0300, Dan Carpenter wrote: > On Fri, Sep 23, 2011 at 06:38:17PM +0200, Julian Andres Klode wrote: > > If nvec_write_async() fails, return -1 in the relevant > > parts of the PS2 driver. > > > > Returning raw -1 is never the right idea. (It means -EPERM). Save > the return code from the lower layers and return that. I did this because serio_write() returns -1 if serio->write is not available, so I though I'm supposed to return -1 in case of errors. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
