Re: [PATCH 1/2] drivers/staging/nvec/nvec_kbd.c: Fix checkpatchwarnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg,

Am Thu, 22 Sep 2011 08:47:04 -0700
schrieb Greg KH <gregkh@xxxxxxx>:
> On Thu, Sep 22, 2011 at 04:53:41PM +0300, Leon Romanovsky wrote:
> > On Thu, Sep 22, 2011 at 12:31, Marcos Paulo de Souza
> > <marcos.mage@xxxxxxxxx> wrote:
> > > Was fixed some checkpatch warning, like spaces before if
> > > statements and others.
> > >
> > 
> > Thanks Marcos for your effort, but all nvec related files under
> > heavy rewrite. If we will success in time the code is going to
> > change next merge window. Greg, it is up to you that to do with
> > this patch..
> 
> "heavy rewrite"?  Why?

That was a bit extreme formulation. 

> I will not accept a "replace the old version of the driver with the
> new one", so you all hopefully are going to provide me with a series
> of incremental patches, right?

As Julien said, the ISR of the core is beeing rewritten (once again,
sorry for that). The rest of the patches are mostly cleanups,
documentation and simplifications. The child drivers are mostly
unchanged. With "huge" I meant there are some small (easily to review)
patches.

> Why are you sitting on patches?  Please never do that.

Julien started to work on it just a week ago and was very motivated :-)

So you get what you want as soon as it reached a stable state again.
 
> I'll take this, and any other cleanup patch that is sent to me, you
> need to be able to handle merges with stuff like that.

I fear you can't because it's not based on the version in your tree.
Btw, is there some "current" version of the staging tree available (not
kernel.org), like on github as some other kernel dev did? I'm not sure
against which tree I can rebase the patches.

For anyone interested in the our current development version, there is
a tree at http://gitorious.org/ac100/marvin24s-kernel
(chromeos-ac100-2.6.38 branch).

Thanks

Marc

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux