On Thu, Sep 22, 2011 at 06:34:00AM -0300, Marcos Paulo de Souza wrote:
> Fixed some warnings like, spaces at start of line, ident of switch/case statements, and a
> static variable initialized by 0.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@xxxxxxxxx>
> ---
> @@ -327,9 +317,8 @@ static struct power_supply nvec_psy = {
> .get_property = nvec_power_get_property,
> };
>
> -static int counter = 0;
> +static int counter = 1;
No... You can't randomly change things like that. Why would you
think that 1 is a better value than 0? The point of the checkpatch
warning is that you counter is 0 by default so you don't need to set
it.
static int counter;
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
