Hi, The following set should fix the remaining sparse warnings. Now the module should compile cleanly without any GCC or sparse warnings: $ make C=1 modules CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHECK drivers/staging/xgifb/XGI_main_26.c CC [M] drivers/staging/xgifb/XGI_main_26.o CHECK drivers/staging/xgifb/vb_init.c CC [M] drivers/staging/xgifb/vb_init.o CHECK drivers/staging/xgifb/vb_setmode.c CC [M] drivers/staging/xgifb/vb_setmode.o CHECK drivers/staging/xgifb/vb_util.c CC [M] drivers/staging/xgifb/vb_util.o CHECK drivers/staging/xgifb/vb_ext.c CC [M] drivers/staging/xgifb/vb_ext.o LD [M] drivers/staging/xgifb/xgifb.o Building modules, stage 2. MODPOST 4 modules CC drivers/staging/xgifb/xgifb.mod.o LD [M] drivers/staging/xgifb/xgifb.ko Also brief smoke testing was done. Aaro Koskinen (5): staging: xgifb: main: use readb()/readw() to access iomapped memory staging: xgifb: unify #include order staging: xgifb: vb_init: use readl()/writel() to access iomapped memory staging: xgifb: add missing #include staging: xgifb: update TODO drivers/staging/xgifb/TODO | 1 - drivers/staging/xgifb/XGI_main_26.c | 54 ++++++++++++++-------------------- drivers/staging/xgifb/XGIfb.h | 4 +- drivers/staging/xgifb/vb_init.c | 13 ++++---- drivers/staging/xgifb/vb_setmode.c | 1 + drivers/staging/xgifb/vb_struct.h | 2 +- drivers/staging/xgifb/vb_util.c | 5 ++- drivers/staging/xgifb/vgatypes.h | 2 +- 8 files changed, 36 insertions(+), 46 deletions(-) -- 1.7.2.5 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel