On Thu, Sep 08, 2011 at 06:46:09PM +0200, Arvydas Sidorenko wrote:
> Cleans the typedef declarations in bc_dts_types.h file. Most of them aren't
> used. The ones are used are 'uint32_t' and similar ones, but I don't see the
> point of them since they are declared in stdint.h, unless some sort of embeded
> systems don't have it (no experience with it).
> So simply removing them doesn't cause any compilation errors or warnings on
> my laptop.
>
> Signed-off-by: Arvydas Sidorenko <asido4@xxxxxxxxx>
> ---
> drivers/staging/crystalhd/bc_dts_types.h | 41 +-----------------------------
> 1 files changed, 1 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/bc_dts_types.h b/drivers/staging/crystalhd/bc_dts_types.h
> index d2131e7..42d7cfd 100644
> --- a/drivers/staging/crystalhd/bc_dts_types.h
> +++ b/drivers/staging/crystalhd/bc_dts_types.h
> @@ -29,29 +29,8 @@
> #include <stdint.h>
> #endif
>
> -#ifndef PVOID
> -typedef void *PVOID;
> -#endif
> -
> -#ifndef BOOL
> -typedef int BOOL;
> -#endif
> -
> #if defined(__KERNEL__) || defined(__LINUX_USER__)
>
> -#ifdef __LINUX_USER__ /* Don't include these for KERNEL */
> -typedef uint32_t ULONG;
> -typedef int32_t LONG;
> -typedef void *HANDLE;
> -#ifndef VOID
> -typedef void VOID;
> -#endif
> -typedef void *LPVOID;
> -typedef uint32_t DWORD;
> -typedef uint32_t UINT32;
> -typedef uint32_t *LPDWORD;
> -typedef unsigned char *PUCHAR;
> -
> #ifndef TRUE
> #define TRUE 1
> #endif
You can drop this too, right?
> @@ -70,28 +49,10 @@ typedef unsigned char *PUCHAR;
> #else
>
> #ifndef uint64_t
> -typedef struct _uint64_t {
> +struct _uint64_t {
> uint32_t low_dw;
> uint32_t hi_dw;
> } uint64_t;
> #endif
This whole thing should also be removed.
Care to redo this?
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
