On Sat, Sep 10, 2011 at 02:16:14PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:greg@xxxxxxxxx] > > Sent: Friday, September 09, 2011 4:45 PM > > To: KY Srinivasan > > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang > > Subject: Re: [PATCH 18/25] Staging: hv: storvsc: Eliminate the usage of ext field in > > struct hv_device > > > > On Thu, Sep 08, 2011 at 07:24:29AM -0700, K. Y. Srinivasan wrote: > > > Now, eliminate the usage of ext field in struct hv_device for storvsc driver. > > > We do this by registering pointer to struct storvsc_device as the driver > > > specific data and eliminating the current usage of driver specific data to > > > save and retrieve the pointer to struct Scsi_Host. > > > Additionally, all access to the driver specific data is through > > > the vmbus wrapper functions. > > > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > > --- > > > drivers/staging/hv/storvsc_drv.c | 24 +++++++++++++++--------- > > > 1 files changed, 15 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c > > > index 57c1035..98d47cd 100644 > > > --- a/drivers/staging/hv/storvsc_drv.c > > > +++ b/drivers/staging/hv/storvsc_drv.c > > > @@ -266,6 +266,7 @@ struct storvsc_device { > > > bool destroy; > > > bool drain_notify; > > > atomic_t num_outstanding_req; > > > + struct Scsi_Host *host; > > > > You are properly reference counting this pointer, right? > > The scsi_host_alloc() which we use to allocate the host structure, gives us > the needed reference. Ok, thanks, I missed that. The casting though should be taken out, otherwise the janitor project will just come along and clean it up again... greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
