On Thu, Sep 08, 2011 at 07:24:16AM -0700, K. Y. Srinivasan wrote: > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -299,9 +299,15 @@ static int vmbus_probe(struct device *child_device) > struct hv_driver *drv = > drv_to_hv_drv(child_device->driver); > struct hv_device *dev = device_to_hv_device(child_device); > + const struct hv_vmbus_device_id *dev_id = drv->id_table; > + > + for (; !is_null_guid(dev_id->guid); dev_id++) > + if (!memcmp(&dev_id->guid, &dev->dev_type.b, > + sizeof(uuid_le))) > + break; Don't duplicate this section of code twice (at least) in the driver. Make it a "vmbus_match_device()" function that returns the proper hv_vmbus_device_id * to do something with. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
