On Thu, Sep 01, 2011 at 01:30:31PM -0700, Greg KH wrote: > On Thu, Sep 01, 2011 at 01:27:33PM -0700, Greg KH wrote: > > On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote: > > > 2) With your help, we have fixed all of the issues related to these drivers > > > conforming to the Linux Device Driver model. One of the TODO work items is > > > "audit the vmbus to verify it is working properly with the driver model". > > > > I have a few comments about this, I'll respond in another email. > > Ok, it looks a _lot_ better, but I have a few minor nits, and one larger > one: Oh, here's another issue I forgot about. You can get rid of the 'ext' field of the hv_device structure and use the proper function in the driver core for this type of thing, just wrap it up in your own function to make it "sane" looking, like USB and PCI does with their usb_get_intfdata(), usb_set_intfdata(), pci_get_drvdata(), and pci_set_drvdata() functions. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
