On Fri, Sep 02, 2011 at 12:51:53AM -0700, Gerard Snitselaar wrote:
> #define MAX_LD_SLOT_NUM 10
> -#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> +#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> #define CHECK_FOR_HANG_PERIOD 2 //be equal to watchdog check time
> #define DEFAULT_KEEP_ALIVE_LEVEL 1
> #define DEFAULT_SLOT_NUM 2
It would be better if the 1 and 2 were lined up.
> @@ -591,14 +591,14 @@ typedef struct r8180_priv
> int ForcedDataRate; // Force Data Rate. 0: Auto, 0x02: 1M ~ 0x6C: 54M.)
> u32 NumTxUnicast; //YJ,add,080828,for keep alive
> u8 keepAliveLevel; //YJ,add,080828,for KeepAlive
> - unsigned long NumTxOkTotal;
> + unsigned long NumTxOkTotal;
> u16 LastRetryCnt;
> u16 LastRetryRate;
> unsigned long LastTxokCnt;
> unsigned long LastRxokCnt;
> u16 CurrRetryCnt;
> unsigned long LastTxOKBytes;
> - unsigned long NumTxOkBytesTotal;
> + unsigned long NumTxOkBytesTotal;
> u8 LastFailTxRate;
> long LastFailTxRateSS;
> u8 FailTxRateCount;
These are all higgledy-piggledy.
> @@ -579,7 +579,7 @@ StaRateAdaptive87SE(
> u32 TxThroughput;
> long CurrSignalStrength;
> bool bUpdateInitialGain = false;
> - u8 u1bOfdm=0, u1bCck = 0;
> + u8 u1bOfdm=0, u1bCck = 0;
^^^
Spaces around the '=' char.
> @@ -846,7 +846,7 @@ StaRateAdaptive87SE(
> bTryDown = true;
> priv->TryDownCountLowData += TryDownTh;
> }
> - else if ( (CurrRetryRate<20) && (priv->LastRetryRate<21)) //TO DO: need to consider (RSSI)
> + else if ( (CurrRetryRate<20) && (priv->LastRetryRate<21)) //TO DO: need to consider (RSSI)
^ ^^^ ^^^
Delete extra space, add spaces around the '<' chars.
> --- a/drivers/staging/rtl8187se/r8185b_init.c
> +++ b/drivers/staging/rtl8187se/r8185b_init.c
> @@ -172,7 +172,7 @@ if (offset == PhyAddr) {
> */
> /* NdisAcquireSpinLock( &(pDevice->IoSpinLock) ); */
>
> - for (idx = 0; idx < 30; idx++) {
> + for (idx = 0; idx < 30; idx++) {
^
Delete the second space here.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
