On Wed, Aug 31, 2011 at 04:42:41PM +0300, Oren Weil wrote:
> +static int mei_wd_ops_ping(struct watchdog_device *wd_dev)
> +{
> + int ret = 0;
> + struct mei_device *dev;
> + dev = pci_get_drvdata(mei_device);
> +
> + if (!dev)
> + return -ENODEV;
> +
> + mutex_lock(&dev->device_lock);
> +
> + if (dev->wd_cl.state != MEI_FILE_CONNECTED) {
> + dev_dbg(&dev->pdev->dev, "wd is not connected.\n");
> + ret = -ENODEV;
> + goto end;
> + }
> +
> + /* Check if we can send the ping to HW*/
> + if (dev->mei_host_buffer_is_empty &&
> + mei_flow_ctrl_creds(dev, &dev->wd_cl) > 0) {
> + dev->mei_host_buffer_is_empty = false;
^^^^^^^^^^^^^^^^
This is a two tab indent. Don't do that.
regards,
dan carpenter
> + dev_dbg(&dev->pdev->dev, "sending watchdog ping\n");
> +
> + if (mei_wd_send(dev)) {
> + dev_dbg(&dev->pdev->dev, "wd send failed.\n");
> + ret = -EIO;
> + goto end;
> + }
> +
> + if (mei_flow_ctrl_reduce(dev, &dev->wd_cl)) {
> + dev_dbg(&dev->pdev->dev, "mei_flow_ctrl_reduce() failed.\n");
> + ret = -EIO;
> + goto end;
> + }
> +
> + } else {
> + dev->wd_pending = true;
> + }
> +
> +end:
> + mutex_unlock(&dev->device_lock);
> + return ret;
> +}
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
